t.behrendt/realDynDNS
1
0
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Releases Activity

fix(externalIpProvider/plain): when reading response body #54

Merged
t.behrendt merged 1 commits from fix-issue-reading-response-body into main 2025-11-07 17:14:15 +01:00
Conversation 1 Commits 1 Files Changed 1 +7 -3
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 90d92ef684 - Show all commits

10
pkg/externalIpProvider/plain/plain.go
View File

@@ -2,6 +2,7 @@ package externalIpProvider
import ( import (
"errors" "errors"
"io"
"net" "net"
"net/http" "net/http"
"net/url" "net/url"
@@ -40,12 +41,15 @@ func (p *ExternalIpProviderImplPlain) GetExternalIp() (net.IP, error) {
} }
if res.StatusCode != 200 { if res.StatusCode != 200 {
res.Body.Close()
return nil, errors.New("unexpected status code") return nil, errors.New("unexpected status code")
} }
responseBody := make([]byte, res.ContentLength) responseBody, err := io.ReadAll(res.Body)
res.Body.Read(responseBody) res.Body.Close()
defer res.Body.Close() if err != nil {
return nil, err
}
parsedIp := net.ParseIP(string(responseBody)) parsedIp := net.ParseIP(string(responseBody))
if parsedIp == nil { if parsedIp == nil {