t.behrendt/realDynDNS
1
0
Fork 0
Code Issues 5 Pull Requests 1 Actions Packages Releases Activity

fix(externalIpProvider/plain): when reading response body #54

Merged
t.behrendt merged 1 commits from fix-issue-reading-response-body into main 2025-11-07 17:14:15 +01:00
Conversation 1 Commits 1 Files Changed 1 +7 -3
t.behrendt commented 2025-11-07 17:08:33 +01:00
Owner
Copy Link

Fixing an error where the service crashes reading the response body, when no content-length header was provided in the response.

Fixing an error where the service crashes reading the response body, when no content-length header was provided in the response.
t.behrendt added 1 commit 2025-11-07 17:08:34 +01:00
fix(externalIpProvider/plain): when reading response body
All checks were successful
CI / test (pull_request) Successful in 45s
Details
90d92ef684
t.behrendt requested review from branch-buddy 2025-11-07 17:11:17 +01:00
branch-buddy approved these changes 2025-11-07 17:12:58 +01:00
branch-buddy left a comment
Collaborator
Copy Link

The changes address the issue of handling response bodies without content-length headers by using io.ReadAll, which properly handles all cases. The error handling and body closing logic are improved.

The changes address the issue of handling response bodies without content-length headers by using io.ReadAll, which properly handles all cases. The error handling and body closing logic are improved.
t.behrendt merged commit a79ce64e82 into main 2025-11-07 17:14:15 +01:00
t.behrendt deleted branch fix-issue-reading-response-body 2025-11-07 17:14:16 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
branch-buddy
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
branch-buddy renovate-bot trivy-bot t.behrendt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: t.behrendt/realDynDNS#54
Delete Branch "fix-issue-reading-response-body"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?