branch-buddy
  • Joined on 2025-05-26
branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:33:40 +01:00
chore: update test tooling

Fix the runs-on syntax in workflows/ci.yaml and workflows/cd.yaml to use a valid list format (e.g., runs-on: [ubuntu-latest, linux_amd64])

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:31:40 +01:00
chore: update test tooling

The PR introduces a YAML syntax error in the workflows by using hyphens under runs-on, which is invalid. The changes align with the title for tooling updates but require fixing the CI/CD configuration syntax.

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:31:40 +01:00
chore: update test tooling

Confirm that the added tool dependencies in go.mod/go.sum are necessary and properly versioned

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:31:40 +01:00
chore: update test tooling

Verify that the new test targets (test-unit, test-race) are correctly integrated into the existing test流程

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:31:40 +01:00
chore: update test tooling

Fix the runs-on syntax in workflows/ci.yaml and workflows/cd.yaml to use a valid list format (e.g., runs-on: [ubuntu-latest, linux_amd64])

branch-buddy approved t.behrendt/ts3gotify#71 2025-12-12 19:41:49 +01:00
ci: add semver releases

The changes align with the PR title and description, adding semver release logic via conventional commits and workflow_dispatch support. The code structure appears correct, though further validation of the Docker registry path change ('t00n' → 't.behrendt') would be prudent.

branch-buddy commented on pull request t.behrendt/ts3gotify#71 2025-12-12 19:41:49 +01:00
ci: add semver releases

Confirm that the custom GitHub Action for semantic tagging is properly configured

branch-buddy commented on pull request t.behrendt/ts3gotify#71 2025-12-12 19:41:49 +01:00
ci: add semver releases

Verify if the Docker registry path change from 't00n' to 't.behrendt' is intentional and correct

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:35:44 +01:00
ci: refactor to native change detection

The PR title and description mention replacing the check-changes job with native paths, but the test job's 'if' condition still references the removed check-changes job. This creates an invalid dependency.

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:35:44 +01:00
ci: refactor to native change detection

Verify that all references to the removed job are properly cleaned up

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:35:44 +01:00
ci: refactor to native change detection

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' line from the test job since the check-changes job has been removed

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:35:44 +01:00
ci: refactor to native change detection

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' condition from the 'test' job since the 'check-changes' job has been removed

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:35:44 +01:00
ci: refactor to native change detection

Check if the 'linux_${{ matrix.arch }}' syntax in the test job's runs-on is intentional and properly defined

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:35:44 +01:00
ci: refactor to native change detection

Verify that the refactor properly replaces the external dorny/paths-filter action with native GitHub Actions features

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:35:44 +01:00
ci: refactor to native change detection

Restore the 'check-changes' job or remove its reference from the test job's 'if' condition

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:33:40 +01:00
ci: refactor to native change detection

The PR title and description align with the changes, but there's a critical issue. The 'test' job's 'if' condition still references the removed 'check-changes' job, which no longer exists. This will cause the workflow to fail.

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:33:40 +01:00
ci: refactor to native change detection

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' condition from the 'test' job since the 'check-changes' job has been removed

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:33:40 +01:00
ci: refactor to native change detection

Check if the 'linux_${{ matrix.arch }}' syntax in the test job's runs-on is intentional and properly defined

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:33:40 +01:00
ci: refactor to native change detection

Verify that the refactor properly replaces the external dorny/paths-filter action with native GitHub Actions features

branch-buddy commented on pull request t.behrendt/ts3gotify#70 2025-12-12 13:33:40 +01:00
ci: refactor to native change detection

Restore the 'check-changes' job or remove its reference from the test job's 'if' condition