branch-buddy
  • Joined on 2025-05-26
branch-buddy commented on pull request t.behrendt/renovate-configs#34 2026-02-09 19:44:02 +01:00
feat: add minimumReleaseAge for all deps

Fix JSON syntax error: ensure all objects are properly closed

branch-buddy approved t.behrendt/renovate-configs#33 2026-02-08 20:35:30 +01:00
fix: match managers in ignore of cooldown for local deps

The changes align with the title's intent of configuring matchManagers for cooldown ignore. The JSON syntax is correct. Minor suggestions: title has a typo ('mention manages' → 'match managers') and description is empty.

branch-buddy commented on pull request t.behrendt/renovate-configs#33 2026-02-08 20:35:30 +01:00
fix: match managers in ignore of cooldown for local deps

Add description to explain the purpose of the changes

branch-buddy commented on pull request t.behrendt/renovate-configs#33 2026-02-08 20:35:30 +01:00
fix: match managers in ignore of cooldown for local deps

Update PR title to fix typo: 'fix: match managers in ignore of cooldown for local deps'

branch-buddy approved t.behrendt/renovate-configs#32 2026-02-08 20:01:34 +01:00
feat: ignore cooldown for internal deps

The changes align with the PR title and description. The diff correctly updates configuration files to ignore cooldown for internal deps and ensure all rules extend the common package. No obvious issues or inconsistencies found.

branch-buddy commented on pull request t.behrendt/renovate-configs#32 2026-02-08 20:01:34 +01:00
feat: ignore cooldown for internal deps

Ensure all packageRules for internal deps correctly set minimumReleaseAge to null

branch-buddy commented on pull request t.behrendt/renovate-configs#32 2026-02-08 20:01:34 +01:00
feat: ignore cooldown for internal deps

Verify if renovate.json should still extend the common package as part of the configuration hierarchy

branch-buddy commented on pull request t.behrendt/renovate-configs#32 2026-02-08 20:01:34 +01:00
feat: ignore cooldown for internal deps

Fix the circular extends in common.json by removing the self-reference

branch-buddy commented on pull request t.behrendt/renovate-configs#32 2026-02-08 19:59:00 +01:00
feat: ignore cooldown for internal deps

The PR introduces a circular reference in common.json by extending itself, which is invalid. Additionally, renovate.json no longer extends the common package, which may break the intended configuration hierarchy.

branch-buddy commented on pull request t.behrendt/renovate-configs#32 2026-02-08 19:59:00 +01:00
feat: ignore cooldown for internal deps

Ensure all packageRules for internal deps correctly set minimumReleaseAge to null

branch-buddy commented on pull request t.behrendt/renovate-configs#32 2026-02-08 19:59:00 +01:00
feat: ignore cooldown for internal deps

Verify if renovate.json should still extend the common package as part of the configuration hierarchy

branch-buddy commented on pull request t.behrendt/renovate-configs#32 2026-02-08 19:59:00 +01:00
feat: ignore cooldown for internal deps

Fix the circular extends in common.json by removing the self-reference

ci: replace release-git-tag with shared workflow

The PR aligns with the title and description by replacing the local release-git-tag action with a shared workflow. The YAML syntax is correct and the changes are intentional.

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:33:40 +01:00
chore: update test tooling

The PR introduces several issues that need addressing before merging.

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:33:40 +01:00
chore: update test tooling

The PR description is empty - adding a brief explanation of the changes would improve clarity.

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:33:40 +01:00
chore: update test tooling

The tool directive in go.mod is non-standard and may not function as intended. Consider using go mod tidy or standard tooling practices instead.

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:33:40 +01:00
chore: update test tooling

The go tool gcov2lcov command in the Makefile is incorrect - the tool should be referenced by its full path or ensure it's available in the PATH.

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:33:40 +01:00
chore: update test tooling

The runs-on field in GitHub Actions workflows should be a string, not a list. The current syntax will cause the workflow to fail.

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:33:40 +01:00
chore: update test tooling

Confirm that the added tool dependencies in go.mod/go.sum are necessary and properly versioned

branch-buddy commented on pull request t.behrendt/realDynDNS#75 2026-01-10 21:33:40 +01:00
chore: update test tooling

Verify that the new test targets (test-unit, test-race) are correctly integrated into the existing test流程