t.behrendt/ts3gotify
3
0
Fork 0
Code Issues 1 Pull Requests 5 Actions Packages Activity

ci: refactor to native change detection #70

Merged
t.behrendt merged 1 commits from ci-change-to-native-change-detection into main 2025-12-12 13:33:48 +01:00
Conversation 3 Commits 1 Files Changed 1 +7 -24
t.behrendt commented 2025-12-12 13:27:02 +01:00
Owner
Copy Link

Removing the 3rd party dependent "check-changes" job, while keeping the "test" job. Replacing the check-changes with GitHub Action's native "paths" parameter.

Removing the 3rd party dependent "check-changes" job, while keeping the "test" job. Replacing the check-changes with GitHub Action's native "paths" parameter.
t.behrendt added 1 commit 2025-12-12 13:27:03 +01:00
ci: refactor to native change detection
All checks were successful
CI / Test (pull_request) Successful in 19s
Details
5a44518690
t.behrendt scheduled this pull request to auto merge when all checks succeed 2025-12-12 13:27:15 +01:00
t.behrendt requested review from branch-buddy 2025-12-12 13:27:31 +01:00
branch-buddy reviewed 2025-12-12 13:29:36 +01:00
branch-buddy left a comment
Collaborator
Copy Link

The PR title suggests refactoring to native change detection, but the diff removes the 'check-changes' job which is still referenced in the test job's condition. This creates a dependency on a non-existent job.

The PR title suggests refactoring to native change detection, but the diff removes the 'check-changes' job which is still referenced in the test job's condition. This creates a dependency on a non-existent job.
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Restore the 'check-changes' job or remove its reference from the test job's 'if' condition

Restore the 'check-changes' job or remove its reference from the test job's 'if' condition
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Verify that the refactor properly replaces the external dorny/paths-filter action with native GitHub Actions features

Verify that the refactor properly replaces the external dorny/paths-filter action with native GitHub Actions features
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Check if the 'linux_${{ matrix.arch }}' syntax in the test job's runs-on is intentional and properly defined

Check if the 'linux_${{ matrix.arch }}' syntax in the test job's runs-on is intentional and properly defined
branch-buddy commented 2025-12-12 13:33:40 +01:00
Collaborator
Copy Link

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' condition from the 'test' job since the 'check-changes' job has been removed

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' condition from the 'test' job since the 'check-changes' job has been removed
branch-buddy commented 2025-12-12 13:35:44 +01:00
Collaborator
Copy Link

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' line from the test job since the check-changes job has been removed

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' line from the test job since the check-changes job has been removed
branch-buddy commented 2025-12-12 13:35:44 +01:00
Collaborator
Copy Link

Verify that all references to the removed job are properly cleaned up

Verify that all references to the removed job are properly cleaned up
t.behrendt removed review request for branch-buddy 2025-12-12 13:30:45 +01:00
t.behrendt requested review from branch-buddy 2025-12-12 13:30:49 +01:00
branch-buddy reviewed 2025-12-12 13:33:40 +01:00
branch-buddy left a comment
Collaborator
Copy Link

The PR title and description align with the changes, but there's a critical issue. The 'test' job's 'if' condition still references the removed 'check-changes' job, which no longer exists. This will cause the workflow to fail.

The PR title and description align with the changes, but there's a critical issue. The 'test' job's 'if' condition still references the removed 'check-changes' job, which no longer exists. This will cause the workflow to fail.
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Restore the 'check-changes' job or remove its reference from the test job's 'if' condition

Restore the 'check-changes' job or remove its reference from the test job's 'if' condition
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Verify that the refactor properly replaces the external dorny/paths-filter action with native GitHub Actions features

Verify that the refactor properly replaces the external dorny/paths-filter action with native GitHub Actions features
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Check if the 'linux_${{ matrix.arch }}' syntax in the test job's runs-on is intentional and properly defined

Check if the 'linux_${{ matrix.arch }}' syntax in the test job's runs-on is intentional and properly defined
branch-buddy commented 2025-12-12 13:33:40 +01:00
Collaborator
Copy Link

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' condition from the 'test' job since the 'check-changes' job has been removed

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' condition from the 'test' job since the 'check-changes' job has been removed
branch-buddy commented 2025-12-12 13:35:44 +01:00
Collaborator
Copy Link

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' line from the test job since the check-changes job has been removed

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' line from the test job since the check-changes job has been removed
branch-buddy commented 2025-12-12 13:35:44 +01:00
Collaborator
Copy Link

Verify that all references to the removed job are properly cleaned up

Verify that all references to the removed job are properly cleaned up
t.behrendt merged commit 3b3ad483b7 into main 2025-12-12 13:33:48 +01:00
t.behrendt deleted branch ci-change-to-native-change-detection 2025-12-12 13:33:48 +01:00
branch-buddy reviewed 2025-12-12 13:35:44 +01:00
branch-buddy left a comment
Collaborator
Copy Link

The PR title and description mention replacing the check-changes job with native paths, but the test job's 'if' condition still references the removed check-changes job. This creates an invalid dependency.

The PR title and description mention replacing the check-changes job with native paths, but the test job's 'if' condition still references the removed check-changes job. This creates an invalid dependency.
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Restore the 'check-changes' job or remove its reference from the test job's 'if' condition

Restore the 'check-changes' job or remove its reference from the test job's 'if' condition
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Verify that the refactor properly replaces the external dorny/paths-filter action with native GitHub Actions features

Verify that the refactor properly replaces the external dorny/paths-filter action with native GitHub Actions features
branch-buddy commented 2025-12-12 13:29:36 +01:00
Collaborator
Copy Link

Check if the 'linux_${{ matrix.arch }}' syntax in the test job's runs-on is intentional and properly defined

Check if the 'linux_${{ matrix.arch }}' syntax in the test job's runs-on is intentional and properly defined
branch-buddy commented 2025-12-12 13:33:40 +01:00
Collaborator
Copy Link

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' condition from the 'test' job since the 'check-changes' job has been removed

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' condition from the 'test' job since the 'check-changes' job has been removed
branch-buddy commented 2025-12-12 13:35:44 +01:00
Collaborator
Copy Link

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' line from the test job since the check-changes job has been removed

Remove the 'if: ${{ needs.check-changes.outputs.changes == 'true' }}' line from the test job since the check-changes job has been removed
branch-buddy commented 2025-12-12 13:35:44 +01:00
Collaborator
Copy Link

Verify that all references to the removed job are properly cleaned up

Verify that all references to the removed job are properly cleaned up
Sign in to join this conversation.
Reviewers
No Reviewers
branch-buddy
Labels
Clear labels
Go
action
deps
k8s
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
branch-buddy renovate-bot t.behrendt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: t.behrendt/ts3gotify#70
Delete Branch "ci-change-to-native-change-detection"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?