t.behrendt/sec-actions
0
0
Fork 0
Code Issues 2 Pull Requests Actions Activity

feat(get-images-from-files): add support for helm values #29

Merged
t.behrendt merged 4 commits from feat-get-images-from-files-add-helm-values-support into main 2026-02-05 17:29:01 +01:00
Conversation 3 Commits 4 Files Changed 4
+47 -5
t.behrendt commented 2026-02-05 15:49:34 +01:00
Owner
Copy Link
Copy Source

Adding support for images inside of helm value files as per helm convention.
Limitation: Default images the chart may propose are not exposed and therefore not supported, only what's specifically mentioned in the values file.

Adding support for images inside of helm value files as per helm convention. Limitation: Default images the chart may propose are not exposed and therefore not supported, only what's specifically mentioned in the values file.
t.behrendt added 2 commits 2026-02-05 15:49:35 +01:00
feat(get-images-from-files): add support for helm values d244282e62
docs: better list supported formats
CI / Test Setup Trivy amd64 (pull_request) Successful in 9s
Details
CI / Test Setup DB (pull_request) Successful in 15s
Details
CI / Test Get Images From Files (pull_request) Failing after 22s
Details
CI / Test Setup Trivy arm64 (pull_request) Successful in 25s
Details
8ed8e7304c
t.behrendt requested review from branch-buddy 2026-02-05 15:49:37 +01:00
branch-buddy approved these changes 2026-02-05 15:52:18 +01:00
Dismissed
branch-buddy left a comment
Collaborator
Copy Link
Copy Source

The changes align with the PR title and description, adding Helmfile values support. The diff includes necessary test cases, updates to CI workflow, and README documentation. The awk script correctly handles repository/tag parsing with indentation logic. No obvious issues detected.

The changes align with the PR title and description, adding Helmfile values support. The diff includes necessary test cases, updates to CI workflow, and README documentation. The awk script correctly handles repository/tag parsing with indentation logic. No obvious issues detected.
t.behrendt commented 2026-02-05 15:58:22 +01:00
Author
Owner
Copy Link
Copy Source

The changes align with the PR title and description, adding Helmfile values support. The diff includes necessary test cases, updates to CI workflow, and README documentation. The awk script correctly handles repository/tag parsing with indentation logic. No obvious issues detected.

Well, not quite bro.

> The changes align with the PR title and description, adding Helmfile values support. The diff includes necessary test cases, updates to CI workflow, and README documentation. The awk script correctly handles repository/tag parsing with indentation logic. No obvious issues detected. Well, not quite bro.
t.behrendt added 1 commit 2026-02-05 17:15:17 +01:00
refactor: remove handling of sole repository, always require both repo and tag
CI / Test Setup Trivy amd64 (pull_request) Successful in 9s
Details
CI / Test Setup DB (pull_request) Successful in 15s
Details
CI / Test Get Images From Files (pull_request) Successful in 21s
Details
CI / Test Setup Trivy arm64 (pull_request) Successful in 24s
Details
19cf9c7dd6
t.behrendt dismissed branch-buddy's review 2026-02-05 17:15:17 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

t.behrendt requested review from branch-buddy 2026-02-05 17:16:07 +01:00
t.behrendt added 1 commit 2026-02-05 17:16:44 +01:00
test: add invalid reference to helmfile
CI / Test Setup Trivy amd64 (pull_request) Successful in 9s
Details
CI / Test Setup DB (pull_request) Successful in 16s
Details
CI / Test Get Images From Files (pull_request) Successful in 20s
Details
CI / Test Setup Trivy arm64 (pull_request) Successful in 24s
Details
8f03d59b51
branch-buddy approved these changes 2026-02-05 17:18:45 +01:00
branch-buddy left a comment
Collaborator
Copy Link
Copy Source

The PR aligns with the title and description by adding Helmfile values support. The diff includes necessary test cases, documentation updates, and code changes to extract images from Helm values. No obvious issues detected.

The PR aligns with the title and description by adding Helmfile values support. The diff includes necessary test cases, documentation updates, and code changes to extract images from Helm values. No obvious issues detected.
t.behrendt merged commit 9411465688 into main 2026-02-05 17:29:01 +01:00
t.behrendt deleted branch feat-get-images-from-files-add-helm-values-support 2026-02-05 17:29:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
branch-buddy
Labels
Clear labels
action
automerge
bug
Something is not working
 deps
docker
duplicate
This issue or pull request already exists
 enhancement
New feature
 go
help wanted
Need some help
 invalid
Something is wrong
 k8s
npm
question
More information is needed
 security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
branch-buddy renovate-bot t.behrendt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: t.behrendt/sec-actions#29
Delete Branch "feat-get-images-from-files-add-helm-values-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?