feat(setup-trivy)!: automatically determine arch #14
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: t.behrendt/sec-actions#14
Reference in New Issue
Block a user
Delete Branch "feat-automatically-select-correct-arch"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Mapping x86_64 to "64bit" and aarch64 to "ARM64" as this is how Trivy names their releases.
Adjusted CICD to test-run both amd64 and arm64 versions.
1a1a356184tod33efe2071cba0b6f2d3tof26a0c4a9aThe PR aims to automatically determine architecture, but the implementation has a critical issue. The arch detection script maps x86_64 to '64bit' and aarch64 to 'ARM64', which does not match Trivy's expected architecture names (amd64/arm64). This will cause the curl command to fail as the tarball name will be incorrect.
Remove the
architectureinput from the action.yaml inputs section as it's no longer needed.Fix the README.md table formatting to ensure consistent column alignment.
Verify that the CI matrix correctly handles both architectures without relying on the removed input.
Consider improving the README.md table formatting for better alignment
Verify if the architecture detection logic handles all possible system architecture identifiers
The PR introduces automatic architecture detection, but the
architectureinput is still present in the action.yaml inputs section, which conflicts with the goal of automatic determination. Additionally, the README.md table formatting shows inconsistent column alignment.Remove the
architectureinput from the action.yaml inputs section as it's no longer needed.Fix the README.md table formatting to ensure consistent column alignment.
Verify that the CI matrix correctly handles both architectures without relying on the removed input.
Consider improving the README.md table formatting for better alignment
Verify if the architecture detection logic handles all possible system architecture identifiers
The changes align with the PR title and description. The diff correctly implements automatic architecture detection by mapping system architectures to Trivy's naming convention and adjusts CI/CD to test both amd64 and arm64. The code appears functionally correct.
Remove the
architectureinput from the action.yaml inputs section as it's no longer needed.Fix the README.md table formatting to ensure consistent column alignment.
Verify that the CI matrix correctly handles both architectures without relying on the removed input.
Consider improving the README.md table formatting for better alignment
Verify if the architecture detection logic handles all possible system architecture identifiers
New commits pushed, approval review dismissed automatically according to repository settings
The changes align with the PR title and description. The CI configuration now supports both amd64 and arm64 architectures, and the setup-trivy action automatically detects architecture via uname -m. No obvious issues found.