refactor(setup-db): to run trivy in docker (#54)

As part of our safety initiative, I'm refactoring setup-db to run trivy inside a Docker container with minimal privileges, reducing leakage of secrets, files, etc. to a minimum in case the dependency gets compromised.
Additionally, we are always pinning the trivy docker image to a fixed digest. Renovate has been configured to keep the Trivy image version up-to-date.

Reviewed-on: #54
Reviewed-by: branch-buddy <branch-buddy@t00n.de>
Co-authored-by: Timo Behrendt <t.behrendt@t00n.de>
Co-committed-by: Timo Behrendt <t.behrendt@t00n.de>

renovate.json

@@ -4,6 +4,17 @@
     "local>t.behrendt/renovate-configs:common",
     "local>t.behrendt/renovate-configs:action"
   ],
+  "customManagers": [
+    {
+      "customType": "regex",
+      "description": "Update Trivy docker image",
+      "managerFilePatterns": ["/(^|/)setup-db/action\\.ya?ml$/"],
+      "datasourceTemplate": "docker",
+      "matchStrings": [
+        "default:\\s*\"(?<depName>ghcr\\.io/aquasecurity/trivy):(?<currentValue>[\\d\\.]+)(?:@(?<currentDigest>sha256:[a-f0-9]+))?\""
+      ]
+    }
+  ],
   "packageRules": [
     {
       "matchManagers": ["dockerfile", "kubernetes", "helmfile", "helm-values"],

setup-db/README.md

@@ -2,7 +2,9 @@
 
 A reusable Gitea Action that sets up the Trivy vulnerability database, restoring from cache if available.
 
-**Note:** This action only sets up the database. Trivy itself must be installed separately (e.g., using the `setup-trivy` action).
+The action runs Trivy inside **Docker** with a restricted container configuration so the Trivy runtime is isolated from the host while the database is downloaded into your cache directory.
+
+**Note:** This action only prepares the vulnerability database. If you run Trivy on the runner host for scans (for example `trivy fs .`), install Trivy separately (e.g. with a `setup-trivy` action or your own step).
 
 ## Usage
 
@@ -37,5 +39,8 @@ jobs:
 ## Inputs
 
 | Input            | Description                                                                 | Required | Default |
-| ----------- | --------------------------------- | -------- | ---------------- |
-| `cache-dir` | Path to the Trivy cache directory | No       | `~/.cache/trivy` |
+| ---------------- | --------------------------------------------------------------------------- | -------- | ------- |
+| `cache-dir`      | Path to the Trivy cache directory                                           | No       | `${{ runner.temp }}/trivy` |
+| `trivy-version`  | Docker image reference for Trivy (digest pin recommended)                   | No       | Pinned `ghcr.io/aquasecurity/trivy` image in `action.yaml` |
+
+**`trivy-version` is optional.** If you omit it, the action uses the default image (version and digest) from `action.yaml`. Set it only when you need a different Trivy image or your own digest pin.

setup-db/action.yaml

@@ -10,6 +10,10 @@ inputs:
     description: "Path to the Trivy cache directory (default: ${{runner.temp}}/trivy)"
     required: false
     default: "${{ runner.temp }}/trivy"
+  trivy-version:
+    description: "Trivy docker image version to use (full image reference including digest is recommended)"
+    required: false
+    default: "ghcr.io/aquasecurity/trivy:0.69.3@sha256:bcc376de8d77cfe086a917230e818dc9f8528e3c852f7b1aff648949b6258d1c"
 
 outputs:
   cache-dir:
@@ -24,7 +28,7 @@ runs:
       run: |
         echo "current-date=$(date +%Y-%m-%d)" >> $GITHUB_OUTPUT
     - id: restore-db
-      uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
+      uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5
       with:
         path: ${{ inputs.cache-dir }}
         key: trivy-db-${{ steps.current-date.outputs.current-date }}
@@ -32,4 +36,21 @@ runs:
           trivy-db-${{ steps.current-date.outputs.current-date }}
     - if: steps.restore-db.outputs.cache-hit != 'true'
       shell: bash
-      run: trivy fs --download-db-only --cache-dir "${{ inputs.cache-dir }}"
+      run: |
+        docker run --rm \
+          --name trivy-db-download \
+          --user "$(id -u):$(id -g)" \
+          --read-only \
+          --env-file /dev/null \
+          --cap-drop ALL \
+          --pids-limit 64 \
+          --memory=512m \
+          --memory-swap=512m \
+          --cpus=1 \
+          --ipc private \
+          --cgroupns private \
+          --security-opt no-new-privileges \
+          --security-opt apparmor=docker-default \
+          --tmpfs /tmp:rw,noexec,nosuid,nodev,size=1g \
+          --mount type=bind,src=${{ inputs.cache-dir }},dst=/cache \
+          ${{ inputs.trivy-version }} fs --download-db-only --cache-dir /cache

setup-trivy/action.yaml

@@ -40,7 +40,7 @@ runs:
         echo "VERSION=$VERSION" >> $GITHUB_OUTPUT
     - name: Cache Trivy binary
       id: cache-trivy
-      uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5
+      uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5
       with:
         path: /usr/local/bin/trivy
         key: trivy-${{ steps.version.outputs.version }}-${{ steps.arch.outputs.arch }}