t.behrendt/renovate-configs
1
0
Fork 0
Code Issues 6 Pull Requests Actions Releases Activity

fix: fix internal package name regex and field and remove package groups #38

Merged
t.behrendt merged 1 commits from fix-exclude-internal-packages-from-min-release-age into main 2026-02-14 12:57:41 +01:00
Conversation 2 Commits 1 Files Changed 1 +1 -2
t.behrendt commented 2026-02-14 12:47:38 +01:00
Owner
Copy Link

Dropping the "matchManagers" as we actually want to match anything, regardless of manager.
Also fixing the regex, wasn't valid before.
Also renaming the "matchPackagePatterns" to "matchPackageNames" as the previous value isn't supported anymore..

Since it's JSON, renovate needs the regex to be quoted. See example:

{
  "packageRules": [
    {
      "matchDatasources": ["npm"],
      "matchPackageNames": ["/^angular/"],
      "groupName": "Angular"
    }
  ]
}
Dropping the "matchManagers" as we actually want to match anything, regardless of manager. Also fixing the regex, wasn't valid before. Also renaming the "matchPackagePatterns" to "matchPackageNames" as the previous value isn't supported anymore.. Since it's JSON, renovate needs the regex to be quoted. See example: ```json { "packageRules": [ { "matchDatasources": ["npm"], "matchPackageNames": ["/^angular/"], "groupName": "Angular" } ] } ```
t.behrendt added 1 commit 2026-02-14 12:47:38 +01:00
fix: fix internal package name regex and field and remove package groups
All checks were successful
CI / Test (action.json) (pull_request) Successful in 14s
Details
CI / Test (helm.json) (pull_request) Successful in 13s
Details
CI / Test (k8s.json) (pull_request) Successful in 45s
Details
CI / Test (common.json) (pull_request) Successful in 48s
Details
CI / Test (docker-compose.json) (pull_request) Successful in 1m2s
Details
b1cd7c0dc7
t.behrendt requested review from branch-buddy 2026-02-14 12:49:13 +01:00
branch-buddy approved these changes 2026-02-14 12:53:07 +01:00
branch-buddy left a comment
Collaborator
Copy Link

The regex pattern in matchPackageNames appears to have syntax issues. The pattern starts with / but is enclosed in quotes, which may not function as intended. Also, the trailing / in the original matchPackagePatterns may be incorrect.

The regex pattern in matchPackageNames appears to have syntax issues. The pattern starts with / but is enclosed in quotes, which may not function as intended. Also, the trailing / in the original matchPackagePatterns may be incorrect.
branch-buddy commented 2026-02-14 12:53:07 +01:00
Collaborator
Copy Link

Verify the regex syntax for matchPackageNames to ensure it correctly matches intended patterns.

Verify the regex syntax for matchPackageNames to ensure it correctly matches intended patterns.
branch-buddy commented 2026-02-14 12:53:07 +01:00
Collaborator
Copy Link

Check if the trailing / in the original matchPackagePatterns was intentional.

Check if the trailing / in the original matchPackagePatterns was intentional.
branch-buddy commented 2026-02-14 12:53:07 +01:00
Collaborator
Copy Link

Ensure the renaming from matchPackagePatterns to matchPackageNames aligns with the new logic.

Ensure the renaming from matchPackagePatterns to matchPackageNames aligns with the new logic.
branch-buddy commented 2026-02-14 12:57:29 +01:00
Collaborator
Copy Link

Verify that all instances of "matchManagers" are removed from related configurations

Verify that all instances of "matchManagers" are removed from related configurations
branch-buddy commented 2026-02-14 12:57:29 +01:00
Collaborator
Copy Link

Ensure the regex pattern continues to correctly match intended package names

Ensure the regex pattern continues to correctly match intended package names
branch-buddy commented 2026-02-14 12:57:29 +01:00
Collaborator
Copy Link

Confirm that the JSON structure remains valid across all affected files

Confirm that the JSON structure remains valid across all affected files
t.behrendt marked this conversation as resolved
t.behrendt removed review request for branch-buddy 2026-02-14 12:56:24 +01:00
branch-buddy approved these changes 2026-02-14 12:57:29 +01:00
branch-buddy left a comment
Collaborator
Copy Link

The changes align with the PR title and description. The regex pattern was corrected to start with /, and "matchManagers" was removed as specified. The JSON syntax is valid and matches the provided example.

The changes align with the PR title and description. The regex pattern was corrected to start with /, and "matchManagers" was removed as specified. The JSON syntax is valid and matches the provided example.
branch-buddy commented 2026-02-14 12:53:07 +01:00
Collaborator
Copy Link

Verify the regex syntax for matchPackageNames to ensure it correctly matches intended patterns.

Verify the regex syntax for matchPackageNames to ensure it correctly matches intended patterns.
branch-buddy commented 2026-02-14 12:53:07 +01:00
Collaborator
Copy Link

Check if the trailing / in the original matchPackagePatterns was intentional.

Check if the trailing / in the original matchPackagePatterns was intentional.
branch-buddy commented 2026-02-14 12:53:07 +01:00
Collaborator
Copy Link

Ensure the renaming from matchPackagePatterns to matchPackageNames aligns with the new logic.

Ensure the renaming from matchPackagePatterns to matchPackageNames aligns with the new logic.
branch-buddy commented 2026-02-14 12:57:29 +01:00
Collaborator
Copy Link

Verify that all instances of "matchManagers" are removed from related configurations

Verify that all instances of "matchManagers" are removed from related configurations
branch-buddy commented 2026-02-14 12:57:29 +01:00
Collaborator
Copy Link

Ensure the regex pattern continues to correctly match intended package names

Ensure the regex pattern continues to correctly match intended package names
branch-buddy commented 2026-02-14 12:57:29 +01:00
Collaborator
Copy Link

Confirm that the JSON structure remains valid across all affected files

Confirm that the JSON structure remains valid across all affected files
t.behrendt marked this conversation as resolved
t.behrendt merged commit e8e303565a into main 2026-02-14 12:57:41 +01:00
t.behrendt deleted branch fix-exclude-internal-packages-from-min-release-age 2026-02-14 12:57:41 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
branch-buddy
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
branch-buddy renovate-bot t.behrendt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: t.behrendt/renovate-configs#38
Delete Branch "fix-exclude-internal-packages-from-min-release-age"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?