chore: update test tooling #75

Merged
t.behrendt merged 4 commits from chore-update-test-tooling into main 2026-01-10 21:42:49 +01:00
Owner
No description provided.
t.behrendt added 4 commits 2026-01-10 21:26:35 +01:00
t.behrendt requested review from branch-buddy 2026-01-10 21:26:44 +01:00
branch-buddy reviewed 2026-01-10 21:31:40 +01:00
branch-buddy left a comment
Collaborator

The PR introduces a YAML syntax error in the workflows by using hyphens under runs-on, which is invalid. The changes align with the title for tooling updates but require fixing the CI/CD configuration syntax.

The PR introduces a YAML syntax error in the workflows by using hyphens under runs-on, which is invalid. The changes align with the title for tooling updates but require fixing the CI/CD configuration syntax.
Collaborator

Fix the runs-on syntax in workflows/ci.yaml and workflows/cd.yaml to use a valid list format (e.g., runs-on: [ubuntu-latest, linux_amd64])

Fix the runs-on syntax in workflows/ci.yaml and workflows/cd.yaml to use a valid list format (e.g., runs-on: [ubuntu-latest, linux_amd64])
Collaborator

Verify that the new test targets (test-unit, test-race) are correctly integrated into the existing test流程

Verify that the new test targets (test-unit, test-race) are correctly integrated into the existing test流程
Collaborator

Confirm that the added tool dependencies in go.mod/go.sum are necessary and properly versioned

Confirm that the added tool dependencies in go.mod/go.sum are necessary and properly versioned
Collaborator

The runs-on field in GitHub Actions workflows should be a string, not a list. The current syntax will cause the workflow to fail.

The `runs-on` field in GitHub Actions workflows should be a string, not a list. The current syntax will cause the workflow to fail.
Collaborator

The go tool gcov2lcov command in the Makefile is incorrect - the tool should be referenced by its full path or ensure it's available in the PATH.

The `go tool gcov2lcov` command in the Makefile is incorrect - the tool should be referenced by its full path or ensure it's available in the PATH.
Collaborator

The tool directive in go.mod is non-standard and may not function as intended. Consider using go mod tidy or standard tooling practices instead.

The `tool` directive in go.mod is non-standard and may not function as intended. Consider using `go mod tidy` or standard tooling practices instead.
Collaborator

The PR description is empty - adding a brief explanation of the changes would improve clarity.

The PR description is empty - adding a brief explanation of the changes would improve clarity.
branch-buddy reviewed 2026-01-10 21:33:40 +01:00
branch-buddy left a comment
Collaborator

The PR introduces several issues that need addressing before merging.

The PR introduces several issues that need addressing before merging.
Collaborator

Fix the runs-on syntax in workflows/ci.yaml and workflows/cd.yaml to use a valid list format (e.g., runs-on: [ubuntu-latest, linux_amd64])

Fix the runs-on syntax in workflows/ci.yaml and workflows/cd.yaml to use a valid list format (e.g., runs-on: [ubuntu-latest, linux_amd64])
Collaborator

Verify that the new test targets (test-unit, test-race) are correctly integrated into the existing test流程

Verify that the new test targets (test-unit, test-race) are correctly integrated into the existing test流程
Collaborator

Confirm that the added tool dependencies in go.mod/go.sum are necessary and properly versioned

Confirm that the added tool dependencies in go.mod/go.sum are necessary and properly versioned
Collaborator

The runs-on field in GitHub Actions workflows should be a string, not a list. The current syntax will cause the workflow to fail.

The `runs-on` field in GitHub Actions workflows should be a string, not a list. The current syntax will cause the workflow to fail.
Collaborator

The go tool gcov2lcov command in the Makefile is incorrect - the tool should be referenced by its full path or ensure it's available in the PATH.

The `go tool gcov2lcov` command in the Makefile is incorrect - the tool should be referenced by its full path or ensure it's available in the PATH.
Collaborator

The tool directive in go.mod is non-standard and may not function as intended. Consider using go mod tidy or standard tooling practices instead.

The `tool` directive in go.mod is non-standard and may not function as intended. Consider using `go mod tidy` or standard tooling practices instead.
Collaborator

The PR description is empty - adding a brief explanation of the changes would improve clarity.

The PR description is empty - adding a brief explanation of the changes would improve clarity.
t.behrendt merged commit 603ca25093 into main 2026-01-10 21:42:49 +01:00
t.behrendt deleted branch chore-update-test-tooling 2026-01-10 21:42:49 +01:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: t.behrendt/realDynDNS#75